Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Event s.SuspendStateChanged, this._onSuspendStateChanged, this); 498 WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Event s.SuspendStateChanged, this._onSuspendStateChanged, this);
499 } 499 }
500 500
501 WebInspector.ProfilesPanel.prototype = { 501 WebInspector.ProfilesPanel.prototype = {
502 /** 502 /**
503 * @param {!Event} event 503 * @param {!Event} event
504 */ 504 */
505 _onKeyDown: function(event) 505 _onKeyDown: function(event)
506 { 506 {
507 var handled = false; 507 var handled = false;
508 if (event.keyIdentifier === "Down" && !event.altKey) 508 if (event.key === "ArrowDown" && !event.altKey)
509 handled = this._sidebarTree.selectNext(); 509 handled = this._sidebarTree.selectNext();
510 else if (event.keyIdentifier === "Up" && !event.altKey) 510 else if (event.key === "ArrowUp" && !event.altKey)
511 handled = this._sidebarTree.selectPrevious(); 511 handled = this._sidebarTree.selectPrevious();
512 if (handled) 512 if (handled)
513 event.consume(true); 513 event.consume(true);
514 }, 514 },
515 515
516 /** 516 /**
517 * @override 517 * @override
518 * @return {?WebInspector.SearchableView} 518 * @return {?WebInspector.SearchableView}
519 */ 519 */
520 searchableView: function() 520 searchableView: function()
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
1307 * @return {boolean} 1307 * @return {boolean}
1308 */ 1308 */
1309 handleAction: function(context, actionId) 1309 handleAction: function(context, actionId)
1310 { 1310 {
1311 var panel = WebInspector.context.flavor(WebInspector.ProfilesPanel); 1311 var panel = WebInspector.context.flavor(WebInspector.ProfilesPanel);
1312 console.assert(panel && panel instanceof WebInspector.ProfilesPanel); 1312 console.assert(panel && panel instanceof WebInspector.ProfilesPanel);
1313 panel.toggleRecord(); 1313 panel.toggleRecord();
1314 return true; 1314 return true;
1315 } 1315 }
1316 } 1316 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698