Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 */ 8 */
9 WebInspector.BlockedURLsPane = function() 9 WebInspector.BlockedURLsPane = function()
10 { 10 {
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 /** 112 /**
113 * @this {WebInspector.BlockedURLsPane} 113 * @this {WebInspector.BlockedURLsPane}
114 * @param {!Event} event 114 * @param {!Event} event
115 */ 115 */
116 function keydown(event) 116 function keydown(event)
117 { 117 {
118 if (isEnterKey(event)) { 118 if (isEnterKey(event)) {
119 event.consume(); 119 event.consume();
120 commit.call(this); 120 commit.call(this);
121 } else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc. code || event.keyIdentifier === "U+001B") { 121 } else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc. code || event.key === "Escape") {
122 event.consume(); 122 event.consume();
123 finish.call(this); 123 finish.call(this);
124 this._update(); 124 this._update();
125 } 125 }
126 } 126 }
127 }, 127 },
128 128
129 /** 129 /**
130 * @param {string} url 130 * @param {string} url
131 */ 131 */
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 * @param {string} actionId 302 * @param {string} actionId
303 * @return {boolean} 303 * @return {boolean}
304 */ 304 */
305 handleAction: function(context, actionId) 305 handleAction: function(context, actionId)
306 { 306 {
307 WebInspector.inspectorView.showViewInDrawer("network.blocked-urls"); 307 WebInspector.inspectorView.showViewInDrawer("network.blocked-urls");
308 return true; 308 return true;
309 } 309 }
310 } 310 }
311 311
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698