Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 */ 8 */
9 WebInspector.DevicesView = function() 9 WebInspector.DevicesView = function()
10 { 10 {
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 function updateViewMoreTitle() 513 function updateViewMoreTitle()
514 { 514 {
515 viewMore.textContent = pages.classList.contains("device-view-more-to ggled") ? WebInspector.UIString("View less tabs\u2026") : WebInspector.UIString( "View more tabs\u2026"); 515 viewMore.textContent = pages.classList.contains("device-view-more-to ggled") ? WebInspector.UIString("View less tabs\u2026") : WebInspector.UIString( "View more tabs\u2026");
516 } 516 }
517 517
518 /** 518 /**
519 * @param {!Event} event 519 * @param {!Event} event
520 */ 520 */
521 function newTabKeyDown(event) 521 function newTabKeyDown(event)
522 { 522 {
523 if (event.keyIdentifier === "Enter") { 523 if (event.key === "Enter") {
524 event.consume(true); 524 event.consume(true);
525 openNewTab(); 525 openNewTab();
526 } 526 }
527 } 527 }
528 528
529 function openNewTab() 529 function openNewTab()
530 { 530 {
531 if (section.browser) { 531 if (section.browser) {
532 InspectorFrontendHost.openRemotePage(section.browser.id, newTabI nput.value.trim() || "about:blank"); 532 InspectorFrontendHost.openRemotePage(section.browser.id, newTabI nput.value.trim() || "about:blank");
533 newTabInput.value = ""; 533 newTabInput.value = "";
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 if (transient.length) 687 if (transient.length)
688 title.push(WebInspector.UIString("Transient: %s", transient.join(", "))); 688 title.push(WebInspector.UIString("Transient: %s", transient.join(", ")));
689 if (error.length) 689 if (error.length)
690 title.push(WebInspector.UIString("Error: %s", error.join(", "))); 690 title.push(WebInspector.UIString("Error: %s", error.join(", ")));
691 this._portStatus.title = title.join("; "); 691 this._portStatus.title = title.join("; ");
692 this._portStatus.classList.toggle("hidden", empty); 692 this._portStatus.classList.toggle("hidden", empty);
693 }, 693 },
694 694
695 __proto__: WebInspector.VBox.prototype 695 __proto__: WebInspector.VBox.prototype
696 } 696 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698