Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 * @param {string} originalContent 418 * @param {string} originalContent
419 * @param {!Event} event 419 * @param {!Event} event
420 */ 420 */
421 _promptKeyDown: function(originalContent, event) 421 _promptKeyDown: function(originalContent, event)
422 { 422 {
423 if (isEnterKey(event)) { 423 if (isEnterKey(event)) {
424 event.consume(true); 424 event.consume(true);
425 this._editingCommitted(originalContent); 425 this._editingCommitted(originalContent);
426 return; 426 return;
427 } 427 }
428 if (event.keyIdentifier === "U+001B") { // Esc 428 if (event.key === "Escape") {
429 event.consume(); 429 event.consume();
430 this._editingCancelled(); 430 this._editingCancelled();
431 return; 431 return;
432 } 432 }
433 }, 433 },
434 434
435 /** 435 /**
436 * @param {string} expression 436 * @param {string} expression
437 */ 437 */
438 _applyExpression: function(expression) 438 _applyExpression: function(expression)
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 1411
1412 result = currentName + (result ? "." + result : ""); 1412 result = currentName + (result ? "." + result : "");
1413 current = current.parent; 1413 current = current.parent;
1414 } 1414 }
1415 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId]; 1415 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId];
1416 result = treeOutlineId + (result ? ":" + result : ""); 1416 result = treeOutlineId + (result ? ":" + result : "");
1417 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result; 1417 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result;
1418 return result; 1418 return result;
1419 } 1419 }
1420 } 1420 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698