Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 20334: Sad Tab view for the Mac. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by Avi (ping after 24h)
Modified:
6 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 18

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -2 lines) Patch
A chrome/browser/cocoa/sad_tab_view.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/sad_tab_view.mm View 1 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_view_mac.h View 1 2 4 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents_view_mac.mm View 1 2 3 chunks +33 lines, -0 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 1 2 6 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (0 generated)
Avi (ping after 24h)
Pink: all the squishy ObjC stuff Brett: I can have the view observe the contents ...
8 years, 7 months ago (2009-02-12 22:31:48 UTC) #1
pink (ping after 24hrs)
LGTM with questions addressed http://codereview.chromium.org/20334/diff/1/5 File chrome/browser/cocoa/sad_tab_view.h (right): http://codereview.chromium.org/20334/diff/1/5#newcode18 Line 18: - (id)initWithFrame:(NSRect)frame; inherited, no ...
8 years, 7 months ago (2009-02-12 22:40:20 UTC) #2
Avi (ping after 24h)
http://codereview.chromium.org/20334/diff/1/5 File chrome/browser/cocoa/sad_tab_view.h (right): http://codereview.chromium.org/20334/diff/1/5#newcode18 Line 18: - (id)initWithFrame:(NSRect)frame; On 2009/02/12 22:40:21, pink wrote: > ...
8 years, 7 months ago (2009-02-12 22:50:33 UTC) #3
pink (ping after 24hrs)
http://codereview.chromium.org/20334/diff/1/5 File chrome/browser/cocoa/sad_tab_view.h (right): http://codereview.chromium.org/20334/diff/1/5#newcode18 Line 18: - (id)initWithFrame:(NSRect)frame; On 2009/02/12 22:50:34, Avi wrote: > ...
8 years, 7 months ago (2009-02-12 23:02:06 UTC) #4
brettw
http://codereview.chromium.org/20334/diff/1/2 File chrome/browser/tab_contents/web_contents_view_mac.mm (right): http://codereview.chromium.org/20334/diff/1/2#newcode22 Line 22: NotificationService::current()->AddObserver( Can you use the NotificationRegistrar object instead? ...
8 years, 7 months ago (2009-02-12 23:47:42 UTC) #5
Avi (ping after 24h)
http://codereview.chromium.org/20334/diff/1/5 File chrome/browser/cocoa/sad_tab_view.h (right): http://codereview.chromium.org/20334/diff/1/5#newcode18 Line 18: - (id)initWithFrame:(NSRect)frame; On 2009/02/12 23:02:06, pink wrote: > ...
8 years, 7 months ago (2009-02-13 16:10:48 UTC) #6
Avi (ping after 24h)
Brett--this look good?
8 years, 7 months ago (2009-02-13 20:48:19 UTC) #7
brettw
LGTM. http://codereview.chromium.org/20334/diff/17/19 File chrome/browser/tab_contents/web_contents_view_mac.h (right): http://codereview.chromium.org/20334/diff/17/19#newcode99 Line 99: scoped_cftyperef<SadTabView*> sad_tab_; Note for the future: it ...
8 years, 7 months ago (2009-02-13 21:38:12 UTC) #8
Avi (ping after 24h)
8 years, 7 months ago (2009-02-17 15:10:55 UTC) #9
On 2009/02/13 21:38:12, brettw wrote:
> Note for the future: it would be better to call this ScopedCFTypeRef to match
> Google style. scoped_ptr is from Boost so we keep the name.

OK; out of scope for this review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b