Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 2033383002: Handle use of fromEnvironment from serialized data. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/serialization/modelz.dart
diff --git a/pkg/compiler/lib/src/serialization/modelz.dart b/pkg/compiler/lib/src/serialization/modelz.dart
index 1d220ff54a8b5db26d5761b8209033724691db2e..87f5fbceea5a8f8b7dcc1560eb4420f003181e21 100644
--- a/pkg/compiler/lib/src/serialization/modelz.dart
+++ b/pkg/compiler/lib/src/serialization/modelz.dart
@@ -1157,7 +1157,8 @@ abstract class ConstructorElementZ extends DeserializedElementZ
FunctionTypedElementMixin,
ParametersMixin,
TypedElementMixin,
- MemberElementMixin
+ MemberElementMixin,
+ ConstructorElementCommon
implements
ConstructorElement,
// TODO(johnniwinther): Sort out whether a constructor is a method.
@@ -1177,14 +1178,6 @@ abstract class ConstructorElementZ extends DeserializedElementZ
@override
bool get isExternal => _decoder.getBool(Key.IS_EXTERNAL);
- bool get isFromEnvironmentConstructor {
- return name == 'fromEnvironment' &&
- library.isDartCore &&
- (enclosingClass.name == 'bool' ||
- enclosingClass.name == 'int' ||
- enclosingClass.name == 'String');
- }
-
ConstantConstructor get constantConstructor {
if (isConst && _constantConstructor == null) {
ObjectDecoder data =
@@ -1413,6 +1406,15 @@ class ForwardingConstructorElementZ extends ElementZ
bool get isFromEnvironmentConstructor => false;
@override
+ bool get isIntFromEnvironmentConstructor => false;
+
+ @override
+ bool get isBoolFromEnvironmentConstructor => false;
+
+ @override
+ bool get isStringFromEnvironmentConstructor => false;
+
+ @override
bool get isRedirectingFactory => false;
@override

Powered by Google App Engine
This is Rietveld 408576698