src/accessors.cc - Issue 203333004: Handlification of JSArray::SetElementsLength().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 203333004: Handlification of JSArray::SetElementsLength(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review notes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index 99ea25ad7f56433c161c5ba8869122cda42cbe00..dda1dee08b5f12f24f57cb7aee3ac5f72988165c 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -213,7 +213,9 @@ MaybeObject* Accessors::ArraySetLength(Isolate* isolate,

if (has_exception) return Failure::Exception();

if (uint32_v->Number() == number_v->Number()) {

- return array_handle->SetElementsLength(*uint32_v);

+ Handle<Object> result = JSArray::SetElementsLength(array_handle, uint32_v);

+ RETURN_IF_EMPTY_HANDLE(isolate, result);

+ return *result;

}

return isolate->Throw(

*isolate->factory()->NewRangeError("invalid_array_length",

« no previous file with comments | « no previous file | src/elements.h » ('j') | src/objects.cc » ('J')