Created Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest.
4 years, 6 months ago
(2016-06-03 10:53:30 UTC)
#2
Created Revert of [Autofill] Sort profiles and credit cards by frecency in
PaymentRequest.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033323003/1
4 years, 6 months ago
(2016-06-03 10:53:44 UTC)
#3
4 years, 6 months ago
(2016-06-03 10:54:29 UTC)
#4
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [Autofill] Sort profiles and credit cards by frecency ...
4 years, 6 months ago
(2016-06-03 10:56:16 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of [Autofill] Sort profiles and credit cards by frecency in
PaymentRequest. (patchset #12 id:620001 of
https://codereview.chromium.org/1982623002/ )
Reason for revert:
This broke the downstream clang-clankium-tot-builder, since PersonalDataManager
at least is used by downstream autofill code to get profiles and credit cards:
https://goto.google.com/kneae
Original issue's description:
> Sorted the profiles and credit cards to be used in PaymentRequest.
>
> Also added test methods to set the use count and use date of profiles and
cards.
>
> BUG=609864
> TEST=PersonalDataManagerTestJava
>
> Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> Cr-Commit-Position: refs/heads/master@{#397562}
TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609864
==========
to
==========
Revert of [Autofill] Sort profiles and credit cards by frecency in
PaymentRequest. (patchset #12 id:620001 of
https://codereview.chromium.org/1982623002/ )
Reason for revert:
This broke the downstream clang-clankium-tot-builder, since PersonalDataManager
at least is used by downstream autofill code to get profiles and credit cards:
https://goto.google.com/kneae
Original issue's description:
> Sorted the profiles and credit cards to be used in PaymentRequest.
>
> Also added test methods to set the use count and use date of profiles and
cards.
>
> BUG=609864
> TEST=PersonalDataManagerTestJava
>
> Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> Cr-Commit-Position: refs/heads/master@{#397562}
TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609864
Committed: https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e
Cr-Commit-Position: refs/heads/master@{#397679}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e Cr-Commit-Position: refs/heads/master@{#397679}
4 years, 6 months ago
(2016-06-03 10:56:17 UTC)
#6
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2039493002/ by rouslan@chromium.org. ...
4 years, 6 months ago
(2016-06-03 16:19:26 UTC)
#7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2039493002/ by rouslan@chromium.org.
The reason for reverting is: Clankium failures should not revert Chromium. The
correct course of action is to fix-up the Clankium code, into which Chromium
developers have no visibility..
Issue 2033323003: Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest.
(Closed)
Created 4 years, 6 months ago by johnme
Modified 4 years, 6 months ago
Reviewers: Mathieu, please use gerrit instead, gone, sebsg
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0