Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Issue 2033323002: :in-range and :out-of-range CSS selectors should check 'have range limitations.' (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

:in-range and :out-of-range CSS selectors should check 'have range limitations.' Spec.: https://html.spec.whatwg.org/multipage/scripting.html#selector-in-range These CSS selectors should work only if |min| or |max| attribute has a valid value except for input[type=range] which has default minimum/maximum values. BUG=603268 Committed: https://crrev.com/a543e0c81913215edafb3337ec88c815ddde8c35 Cr-Commit-Position: refs/heads/master@{#397654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 3 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
yosin@, would you review this please?
4 years, 6 months ago (2016-06-03 06:53:43 UTC) #3
yosin_UTC9
lgtm
4 years, 6 months ago (2016-06-03 07:06:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033323002/1
4 years, 6 months ago (2016-06-03 07:06:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 07:52:53 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 07:54:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a543e0c81913215edafb3337ec88c815ddde8c35
Cr-Commit-Position: refs/heads/master@{#397654}

Powered by Google App Engine
This is Rietveld 408576698