chrome/browser/extensions/chrome_extension_chooser_dialog.h - Issue 2033283002: Implement bluetooth chooser for Chrome Apps on non-Mac desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_chooser_dialog.h

Issue 2033283002: Implement bluetooth chooser for Chrome Apps on non-Mac desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_ChooserBubbleUiViewDelegate

Patch Set: implemented bluetooth chooser for Chrome Apps on non-Mac desktops Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.cc » ('j') | chrome/browser/ui/views/extensions/chooser_dialog_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_chooser_dialog.h

diff --git a/chrome/browser/extensions/chrome_extension_chooser_dialog.h b/chrome/browser/extensions/chrome_extension_chooser_dialog.h

index d474e3e59e8a91bc974c58901f5276af74f66e5f..85c2f326e87a17b0e9f4d1b633269240fd17e9ee 100644

--- a/chrome/browser/extensions/chrome_extension_chooser_dialog.h

+++ b/chrome/browser/extensions/chrome_extension_chooser_dialog.h

@@ -6,7 +6,6 @@

#define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_CHOOSER_DIALOG_H_

#include "base/macros.h"

-#include "build/build_config.h"

class ChooserController;

@@ -22,11 +21,7 @@ class ChromeExtensionChooserDialog {

content::WebContents* web_contents() const { return web_contents_; }

-// TODO(juncai): remove this preprocessor directive once the non-Mac

msw 2016/06/03 19:46:24 I'm confused, why remove this if the CL is for "no

juncai 2016/06/07 23:19:39 Actually, this preprocessor directive was removed

-// implementation is done.

-#if defined(OS_MACOSX)

void ShowDialog(ChooserController* chooser_controller) const;

-#endif // defined(OS_MACOSX)

private:

content::WebContents* web_contents_;