Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2033273002: Blimp: Reduced logging serverity for assignment error (Closed)

Created:
4 years, 6 months ago by shaktisahu
Modified:
4 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blimp: Reduced logging serverity for assignment error Blimp client currently crashes with a fatal error message when there is a client-engine version mismatch. The crash is so fast that it doesn't give a chance for the user to try connecting with a different assigner. Reduced the logging level from FATAL to ERROR for assigner response. BUG=615205 Committed: https://crrev.com/b0061b1242d40d9b5dd7d84ee6fb1d65b1eddad6 Cr-Commit-Position: refs/heads/master@{#397584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M blimp/client/session/blimp_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
shaktisahu
4 years, 6 months ago (2016-06-02 23:14:12 UTC) #2
nyquist
lgtm
4 years, 6 months ago (2016-06-03 00:37:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033273002/1
4 years, 6 months ago (2016-06-03 00:38:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:30:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:32:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0061b1242d40d9b5dd7d84ee6fb1d65b1eddad6
Cr-Commit-Position: refs/heads/master@{#397584}

Powered by Google App Engine
This is Rietveld 408576698