Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2033263002: [es7] Array.prototype.includes should be unscopable (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es7] Array.prototype.includes should be unscopable R=littledan@chromium.org BUG=v8:5059 Committed: https://crrev.com/611257fbb102eb7cb65c4de556342b8309c6f441 Cr-Commit-Position: refs/heads/master@{#36721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/js/array.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es7/array-includes.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 6 months ago (2016-06-02 22:09:51 UTC) #1
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-03 08:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033263002/1
4 years, 6 months ago (2016-06-03 18:03:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:28:30 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:30:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/611257fbb102eb7cb65c4de556342b8309c6f441
Cr-Commit-Position: refs/heads/master@{#36721}

Powered by Google App Engine
This is Rietveld 408576698