Issue 2033243004: Make GetDevFont() return a CFX_Font* instead of void*

Issue 2033243004: Make GetDevFont() return a CFX_Font* instead of void* (Closed)

Created:
4 years, 6 months ago by Tom Sepez

Modified:
4 years, 6 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Make GetDevFont() return a CFX_Font* instead of void* Then we can remove a bunch of casts. Committed: https://pdfium.googlesource.com/pdfium/+/48ddd86c45b437151d660758befbebec242d407d

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -17 lines)			Patch
M	xfa/fde/fde_gedevice.cpp	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	xfa/fgas/font/fgas_font.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	xfa/fgas/font/fgas_gefont.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	xfa/fgas/font/fgas_stdfontmgr.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	xfa/fwl/basewidget/fwl_barcodeimp.cpp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

Tom Sepez

Wei, for review. This is what I had set out to do before I realized ...

4 years, 6 months ago (2016-06-03 23:30:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033243004/20001

4 years, 6 months ago (2016-06-06 17:08:16 UTC) #5

commit-bot: I haz the power

4 years, 6 months ago (2016-06-06 17:52:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/48ddd86c45b437151d660758befbebec242d...