Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2033193002: Remove use of deprecated MessageLoop methods in crypto. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated MessageLoop methods in crypto. MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=agl@chromium.org Committed: https://crrev.com/34e1fb8796fcb0b71ea3772c81f7d67982496f74 Cr-Commit-Position: refs/heads/master@{#398549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M crypto/nss_util.cc View 6 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-06 16:40:11 UTC) #2
agl
lgtm
4 years, 6 months ago (2016-06-08 00:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033193002/1
4 years, 6 months ago (2016-06-08 13:35:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 14:43:35 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 14:46:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34e1fb8796fcb0b71ea3772c81f7d67982496f74
Cr-Commit-Position: refs/heads/master@{#398549}

Powered by Google App Engine
This is Rietveld 408576698