cc : Fix hit testing bug in resourceless software draw mode

cc : Fix hit testing bug in resourceless software draw mode

Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8d0064fad7a0842a60a61a00ffc58775f8c8f982
Cr-Commit-Position: refs/heads/master@{#397543}

[jaydasika, 2016-06-02 20:03:15]

Description was changed from

==========
cc : Fix hit testing bug in resourceless software draw mode

Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
==========

to

==========
cc : Fix hit testing bug in resourceless software draw mode

Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-06-02 20:09:39]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-06-02 20:09:39]

PTAL

[ajuma, 2016-06-02 20:38:50]

lgtm with a nit about the test:

https://codereview.chromium.org/2033163003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2033163003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:2470: EXPECT_TRUE(result_layer);
Please check for the actual layer that's hit here, rather than only checking for
the result being non-null.

[jaydasika, 2016-06-02 20:45:53]

https://codereview.chromium.org/2033163003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2033163003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:2470: EXPECT_TRUE(result_layer);
On 2016/06/02 20:38:49, ajuma wrote:
> Please check for the actual layer that's hit here, rather than only checking
for
> the result being non-null.

Done.

[jaydasika, 2016-06-02 20:46:02]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-06-02 20:46:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2033163003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 20:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033163003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033163003/40001

[commit-bot: I haz the power, 2016-06-02 23:35:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-02 23:36:11]

Description was changed from

==========
cc : Fix hit testing bug in resourceless software draw mode

Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Fix hit testing bug in resourceless software draw mode

Hit testing assumes that the transform node corresponding to target id
of clip node always has a render surface. This is not true when we are
in resourceless software draw mode.

BUG=614438, 604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8d0064fad7a0842a60a61a00ffc58775f8c8f982
Cr-Commit-Position: refs/heads/master@{#397543}
==========

[commit-bot: I haz the power, 2016-06-02 23:36:12]

Patchset 3 (id:??) landed as
https://crrev.com/8d0064fad7a0842a60a61a00ffc58775f8c8f982
Cr-Commit-Position: refs/heads/master@{#397543}