Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: src/compiler/representation-change.cc

Issue 2033143002: [turbofan] Add frame state propagation to linearizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-6
Patch Set: Add TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/representation-change.cc
diff --git a/src/compiler/representation-change.cc b/src/compiler/representation-change.cc
index 9777dbb05204f2deb944fa551052b2ef54bbda01..d4b7ad91c35ba5a730ff719d5b8782b485d2670d 100644
--- a/src/compiler/representation-change.cc
+++ b/src/compiler/representation-change.cc
@@ -447,13 +447,10 @@ Node* RepresentationChanger::InsertConversion(Node* node, const Operator* op,
Node* use_node) {
if (op->ControlInputCount() > 0) {
// If the operator can deoptimize (which means it has control
- // input), we need to connect it to the effect and control chains
- // and also provide it with a frame state.
+ // input), we need to connect it to the effect and control chains.
Node* effect = NodeProperties::GetEffectInput(use_node);
Node* control = NodeProperties::GetControlInput(use_node);
- Node* frame_state = NodeProperties::FindFrameStateBefore(use_node);
- Node* conversion =
- jsgraph()->graph()->NewNode(op, node, frame_state, effect, control);
+ Node* conversion = jsgraph()->graph()->NewNode(op, node, effect, control);
NodeProperties::ReplaceControlInput(use_node, control);
NodeProperties::ReplaceEffectInput(use_node, effect);
return conversion;
@@ -559,8 +556,7 @@ Node* RepresentationChanger::GetCheckedWord32RepresentationFor(
}
if (op->ControlInputCount() > 0) {
// If the operator can deoptimize (which means it has control
- // input), we need to connect it to the effect and control chains
- // and also provide it with a frame state.
+ // input), we need to connect it to the effect and control chains.
UNIMPLEMENTED();
}
return jsgraph()->graph()->NewNode(op, node);
« src/compiler/effect-control-linearizer.cc ('K') | « src/compiler/operator-properties.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698