Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chromeos/ime/xkeyboard.cc

Issue 203313004: Revert 257618 "roll clang 198389:202554" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/build/config/compiler/BUILD.gn ('k') | trunk/src/third_party/libxml/libxml.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chromeos/ime/xkeyboard.cc
===================================================================
--- trunk/src/chromeos/ime/xkeyboard.cc (revision 257619)
+++ trunk/src/chromeos/ime/xkeyboard.cc (working copy)
@@ -153,7 +153,7 @@
if (!xkb_desc)
return kBadMask;
- if (xkb_desc->dpy && xkb_desc->names /*TODO && xkb_desc->names->vmods*/) {
+ if (xkb_desc->dpy && xkb_desc->names && xkb_desc->names->vmods) {
const std::string string_to_find(kNumLockVirtualModifierString);
for (size_t i = 0; i < XkbNumVirtualMods; ++i) {
const unsigned int virtual_mod_mask = 1U << i;
« no previous file with comments | « trunk/src/build/config/compiler/BUILD.gn ('k') | trunk/src/third_party/libxml/libxml.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698