Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 203313002: Measure how often Attr needs its associated Element (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Measure how often Attr needs its associated Element The new Attr in http://dom.spec.whatwg.org/#attr does not inherit from Node and is not attached to an Element. To determine if this is Web compatible, measure how often the associated Element is actually needed in the Attr.value getter and setter. The counters could be affected by Attr.nodeValue and the internal Attr::childrenChanged(), so measure those too. On the assumption that they will be very rarely hit compared to Attr.value, don't bother discriminating whether or not Element was needed. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M Source/core/dom/Attr.h View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/dom/Attr.cpp View 8 chunks +21 lines, -6 lines 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
PTAL. There are many ways to get this wrong and I went back and forth ...
6 years, 9 months ago (2014-03-18 17:21:05 UTC) #1
philipj_slow
There's also some discussion in https://www.w3.org/Bugs/Public/show_bug.cgi?id=25016
6 years, 9 months ago (2014-03-18 17:50:38 UTC) #2
philipj_slow
Per https://www.w3.org/Bugs/Public/show_bug.cgi?id=25016#c7 I think that this CL is pointless, I was tricked by a spec ...
6 years, 9 months ago (2014-03-18 18:02:16 UTC) #3
abarth-chromium
6 years, 9 months ago (2014-03-18 22:50:45 UTC) #4
We can probably just close the CL.

Powered by Google App Engine
This is Rietveld 408576698