Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 2033093004: DevTools: fix invalid outline style across inputs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
index 43f27977dcae2f489b7b6c9325a9c7fbaf3e1d0d..636c7c5410214f38cfa05d238128a3106bfe3ebc 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
@@ -112,7 +112,7 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
otherUserAgentElement.value = userAgentSetting.get();
otherUserAgentElement.title = userAgentSetting.get();
otherUserAgentElement.placeholder = WebInspector.UIString("Enter a custom user agent");
- otherUserAgentElement.required = true;
+ var otherUserAgentSetter = WebInspector.bindInput(otherUserAgentElement, textChanged, (value) => (value.length > 0), false);
dgozman 2016/06/02 21:20:51 value => !!value
luoe 2016/06/02 23:07:02 Done.
settingChanged();
userAgentSelectElement.addEventListener("change", userAgentSelected, false);
@@ -123,8 +123,8 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
var value = userAgentSelectElement.options[userAgentSelectElement.selectedIndex].value;
if (value !== customOverride.value) {
userAgentSetting.set(value);
- otherUserAgentElement.value = value;
otherUserAgentElement.title = value;
+ otherUserAgentSetter(value);
} else {
otherUserAgentElement.select();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698