DevTools: fix invalid outline style across inputs

third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.NetworkConfigView = function()
 {
@@ skipping 94 matching lines @@
             groupElement.appendChild(new Option(userAgentVersion.title, userAgentVersion.value));
     }
 
     userAgentSelectElement.selectedIndex = 0;
 
     var otherUserAgentElement = createElement("input");
     otherUserAgentElement.type = "text";
     otherUserAgentElement.value = userAgentSetting.get();
     otherUserAgentElement.title = userAgentSetting.get();
     otherUserAgentElement.placeholder = WebInspector.UIString("Enter a custom user agent");
-    otherUserAgentElement.required = true;
+    var otherUserAgentSetter = WebInspector.bindInput(otherUserAgentElement, textChanged, (value) => (value.length > 0), false);

[dgozman, 2016/06/02 21:20:51]

value => !!value

[luoe, 2016/06/02 23:07:02]

Done.

 
     settingChanged();
     userAgentSelectElement.addEventListener("change", userAgentSelected, false);
     otherUserAgentElement.addEventListener("input", textChanged, false);

[dgozman, 2016/06/02 21:20:51]

Remove this line?

[luoe, 2016/06/02 23:07:03]

Without this, textChanged only gets called when the user blurs or presses enter
after a change, but we really want to call it on every input.

I added a new boolean option to bindInput called 'applyOnInput'.  What do you
think?

 
     function userAgentSelected()
     {
         var value = userAgentSelectElement.options[userAgentSelectElement.selectedIndex].value;
         if (value !== customOverride.value) {
             userAgentSetting.set(value);
-            otherUserAgentElement.value = value;
             otherUserAgentElement.title = value;
+            otherUserAgentSetter(value);
         } else {
             otherUserAgentElement.select();
         }
     }
 
     function settingChanged()
     {
         var value = userAgentSetting.get();
         var options = userAgentSelectElement.options;
         var selectionRestored = false;
@@ skipping 121 matching lines @@
      * @param {!WebInspector.Context} context
      * @param {string} actionId
      * @return {boolean}
      */
     handleAction: function(context, actionId)
     {
         WebInspector.inspectorView.showViewInDrawer("network.config");
         return true;
     }
 }