tools/android/loading/sandwich_metrics.py - Issue 2033093002: sandwich: Merge cache-validation.json and urls-for-resources.json tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/sandwich_metrics.py

Issue 2033093002: sandwich: Merge cache-validation.json and urls-for-resources.json tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot PrefetchBenchmarkBuilder._PopulateCommonPipelines()'s docstring =D Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/sandwich_metrics.py

diff --git a/tools/android/loading/sandwich_metrics.py b/tools/android/loading/sandwich_metrics.py

index 351bd8376594acba172e715c5f38c5da3476244d..f46e79a78a26747fb52c069c539bd40817c9d289 100644

--- a/tools/android/loading/sandwich_metrics.py

+++ b/tools/android/loading/sandwich_metrics.py

@@ -135,7 +135,7 @@ def _GetWebPageTrackedEvents(tracing_track):

# hence the first navigationStart in the trace registers the correct frame

# id.

if event_name == 'navigationStart':

- logging.info('Found navigationStart at: %f', event.start_msec)

+ logging.info(' Found navigationStart at: %f', event.start_msec)

main_frame_id = event.args['frame']

continue

@@ -147,7 +147,7 @@ def _GetWebPageTrackedEvents(tracing_track):

# important events (like requestStart) do not have a frame id attached.

if event_name in _TRACKED_EVENT_NAMES and event_name not in tracked_events:

tracked_events[event_name] = event

- logging.info('Event %s first appears at: %f', event_name,

+ logging.info(' Event %s first appears at: %f', event_name,

event.start_msec)

return tracked_events

« no previous file with comments | « no previous file | tools/android/loading/sandwich_prefetch.py » ('j') | tools/android/loading/sandwich_prefetch.py » ('J')