Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2033053002: Compiler::CompileBaseline didn't ensure that the closure had literals. (Closed)

Created:
4 years, 6 months ago by mvstanton
Modified:
4 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Compiler::CompileBaseline didn't ensure that the closure had literals. It should work just the same as Compile() and CompileOptimized(). R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/4f205165de7bb4f4fa5a410c15ad9b3a2f3358ac Cr-Commit-Position: refs/heads/master@{#36680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Michael, here is the CL we discussed, thx for the look! --Mike
4 years, 6 months ago (2016-06-02 12:05:35 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 6 months ago (2016-06-02 12:32:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033053002/1
4 years, 6 months ago (2016-06-02 12:41:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 12:43:03 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:45:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f205165de7bb4f4fa5a410c15ad9b3a2f3358ac
Cr-Commit-Position: refs/heads/master@{#36680}

Powered by Google App Engine
This is Rietveld 408576698