third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get rid of hasDefiniteLogicalWidth() Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index 3087cc8eeb2fd9da5c21fae7e3442a0c6f3a899d..15c9f6182cb2637f9ba92b0c56df1ceb1102db3e 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -5,7 +5,7 @@ testGridDefinitionsValues(document.getElementById("gridWithNoneElement"), "none"

testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "10px", "15px");

testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "400px", "150px");

testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "0px", "0px");

-testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWithChildren"), "7px", "11px");

+testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWithChildren"), "3.5px", "11px");

testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px", "0px");

testGridDefinitionsValues(document.getElementById("gridWithAutoWithoutSizeElement"), "0px", "0px");

testGridDefinitionsValues(document.getElementById("gridWithAutoWithChildrenElement"), "7px", "11px");