Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor fixes on tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 1cbedcad8db3996a92f175d35cad6c5aeda90a76..24e15fcb1b7b1832973fbed06f9aa1745986e169 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4247,35 +4247,6 @@ void LayoutBox::clearLayoutOverflow()
m_overflow->setLayoutOverflow(noOverflowRect());
}
-static bool logicalWidthIsResolvable(const LayoutBox& layoutBox)
-{
- const LayoutBox* box = &layoutBox;
- while (!box->isLayoutView() && !box->isOutOfFlowPositioned()
- && (box->style()->logicalWidth().isAuto() || box->isAnonymousBlock())
- && !box->hasOverrideContainingBlockLogicalWidth())
- box = box->containingBlock();
-
- if (box->style()->logicalWidth().isFixed())
- return true;
- if (box->isLayoutView())
- return true;
- // The size of the containing block of an absolutely positioned element is always definite with respect to that
- // element (http://dev.w3.org/csswg/css-sizing-3/#definite).
- if (box->isOutOfFlowPositioned())
- return true;
- if (box->hasOverrideContainingBlockLogicalWidth())
- return box->overrideContainingBlockContentLogicalWidth() != -1;
- if (box->style()->logicalWidth().hasPercent())
- return logicalWidthIsResolvable(*box->containingBlock());
-
- return false;
-}
-
-bool LayoutBox::hasDefiniteLogicalWidth() const
-{
- return logicalWidthIsResolvable(*this);
-}
-
bool LayoutBox::percentageLogicalHeightIsResolvable() const
{
Length fakeLength(100, Percent);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698