third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js - Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fixes on tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

index e2197d2d48efe5f5d9c2463256b78d40f8fc4d62..d1f577f5392a4a3a2f3ecdcb4ef3a4611b6e5065 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

@@ -2,8 +2,8 @@ description('Test that setting and getting grid-template-columns and grid-templa

debug("Test getting |grid-template-columns| and |grid-template-rows| set through CSS");

testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "7px 11px", "17px 2px");

-testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "424px 792px", "162px 312px");

-testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "7px 0px", "11px 0px");

+testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "400px 800px", "162px 312px");

+testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "3.5px 7px", "11px 0px");

testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "0px 17px", "0px 3px");

testGridDefinitionsValues(document.getElementById("gridWithEMElement"), "100px 120px", "150px 170px");

testGridDefinitionsValues(document.getElementById("gridWithThreeItems"), "15px 0px 100px", "120px 18px 0px");