third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html - Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html

Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fixes on tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-percentage-columns.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html

index 3de4de69636eee6d8b2842ca529241d0fd1a84e8..149fc388132fcff24c77527c30697c8cf500029a 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html

@@ -21,7 +21,7 @@

grid-template-rows: [first] 15px;

}

.gridWithPercent {

- grid-template-columns: 53% [last];

+ grid-template-columns: 50% [last];

grid-template-rows: 27% [last];

}

.gridWithAuto {

@@ -104,9 +104,9 @@

debug("Test getting grid-template-columns and grid-template-rows set through CSS");

testGridDefinitionsValues(document.getElementById("gridWithFixedElement"), "[first] 10px", "[first] 15px");

- testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "424px [last]", "162px [last]");

+ testGridDefinitionsValues(document.getElementById("gridWithPercentElement"), "400px [last]", "162px [last]");

testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSize"), "0px [last]", "0px [last]");

- testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWithChildren"), "77px [last]", "22px [last]");

+ testGridDefinitionsValues(document.getElementById("gridWithPercentWithoutSizeWithChildren"), "38.5px [last]", "22px [last]");

testGridDefinitionsValues(document.getElementById("gridWithAutoElement"), "[first] 0px", "0px [last]");

testGridDefinitionsValues(document.getElementById("gridWithAutoWithChildrenElement"), "[first] 77px", "22px [last]");

testGridDefinitionsValues(document.getElementById("gridWithMinMax"), "[first] 80px", "300px [last]");