third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html - Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

Issue 2033033002: [css-grid] Percentage columns can always be resolved during layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get rid of hasDefiniteLogicalWidth() Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet">	4 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel ="stylesheet">

5 <link href="resources/grid.css" rel="stylesheet">	5 <link href="resources/grid.css" rel="stylesheet">

6 <link href="resources/grid-alignment.css" rel="stylesheet">	6 <link href="resources/grid-alignment.css" rel="stylesheet">

7 <style>	7 <style>

8 .definite {	8 .definite {

9 /* Give an explicit size to the grid so that percentage grid tracks have a c onsistent resolution */	9 /* Give an explicit size to the grid so that percentage grid tracks have a c onsistent resolution */

10 width: 800px;	10 width: 800px;

(...skipping 13 matching lines...) Expand all Loading...
24 width: 17px;	24 width: 17px;

25 height: 3px;	25 height: 3px;

26 }	26 }

27	27

28 .gridWithFixed {	28 .gridWithFixed {

29 grid-template-columns: 7px 11px;	29 grid-template-columns: 7px 11px;

30 grid-template-rows: 17px 2px;	30 grid-template-rows: 17px 2px;

31 }	31 }

32	32

33 .gridWithPercent {	33 .gridWithPercent {

34 grid-template-columns: 53% 99%;	34 grid-template-columns: 50% 100%;
	svillar 2016/06/08 10:38:03 why? why? Manuel Rego 2016/06/08 11:56:30 It was to get simpler results on the tests: 50% Show quoted text On 2016/06/08 10:38:03, svillar wrote: > why? It was to get simpler results on the tests: 50% of 7px = 3.5px 100% of 7px = 7px vs 53% of 7px = 3.71px 99% of 7px = 6.93px Otherwise we'll have much more decimals.
35 grid-template-rows: 27% 52%;	35 grid-template-rows: 27% 52%;

36 }	36 }

37 .gridWithAuto {	37 .gridWithAuto {

38 grid-template-columns: auto auto;	38 grid-template-columns: auto auto;

39 grid-template-rows: auto auto;	39 grid-template-rows: auto auto;

40 }	40 }

41 .gridWithEM {	41 .gridWithEM {

42 grid-template-columns: 10em 12em;	42 grid-template-columns: 10em 12em;

43 grid-template-rows: 15em 17em;	43 grid-template-rows: 15em 17em;

44 font: 10px Ahem;	44 font: 10px Ahem;

(...skipping 93 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
138 <div class="grid definite gridWithFractionMinMax" id="gridWithFractionMinMax"></ div>	138 <div class="grid definite gridWithFractionMinMax" id="gridWithFractionMinMax"></ div>

139 <div class="grid definite gridWithCalcCalc" id="gridWithCalcCalc"></div>	139 <div class="grid definite gridWithCalcCalc" id="gridWithCalcCalc"></div>

140 <div class="grid definite gridWithCalcAndFixed" id="gridWithCalcAndFixed"></div>	140 <div class="grid definite gridWithCalcAndFixed" id="gridWithCalcAndFixed"></div>

141 <div class="grid definite gridWithCalcAndMinMax" id="gridWithCalcAndMinMax"></di v>	141 <div class="grid definite gridWithCalcAndMinMax" id="gridWithCalcAndMinMax"></di v>

142 <div class="grid definite gridWithCalcInsideMinMax" id="gridWithCalcInsideMinMax "></div>	142 <div class="grid definite gridWithCalcInsideMinMax" id="gridWithCalcInsideMinMax "></div>

143 <div class="grid definite gridWithAutoInsideMinMax contentStart" id="gridWithAut oInsideMinMax"></div>	143 <div class="grid definite gridWithAutoInsideMinMax contentStart" id="gridWithAut oInsideMinMax"></div>

144 <script src="resources/grid-definitions-parsing-utils.js"></script>	144 <script src="resources/grid-definitions-parsing-utils.js"></script>

145 <script src="resources/grid-columns-rows-get-set-multiple.js"></script>	145 <script src="resources/grid-columns-rows-get-set-multiple.js"></script>

146 </body>	146 </body>

147 </html>	147 </html>

OLD	NEW