Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/ninja.py

Issue 203303011: Fix None target type with Ninja build. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: remove sources Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/ninja/none-rules/gyptest-none-rules.py » ('j') | test/ninja/none-rules/none-rules.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py
index 79245fdfe30f61121f4570db1613d7f376a7cc88..f1166860070f33dfc84b0b8971320246d3ba5a3d 100644
--- a/pylib/gyp/generator/ninja.py
+++ b/pylib/gyp/generator/ninja.py
@@ -483,7 +483,9 @@ class NinjaWriter:
# Write out a link step, if needed.
output = None
is_empty_bundle = not link_deps and not mac_bundle_depends
- if link_deps or self.target.actions_stamp or actions_depends:
+ if spec['type'] == 'none':
+ self.ninja.build(spec['target_name'], 'phony')
+ elif link_deps or self.target.actions_stamp or actions_depends:
output = self.WriteTarget(spec, config_name, config, link_deps,
self.target.actions_stamp or actions_depends)
if self.is_mac_bundle:
« no previous file with comments | « no previous file | test/ninja/none-rules/gyptest-none-rules.py » ('j') | test/ninja/none-rules/none-rules.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698