pylib/gyp/generator/ninja.py - Issue 203303011: Fix None target type with Ninja build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 203303011: Fix None target type with Ninja build. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: fix unittests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index 79245fdfe30f61121f4570db1613d7f376a7cc88..4c17c570c802d31d713e81e6b592b566ff6044fc 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -2125,6 +2125,8 @@ def GenerateOutputForConfig(target_list, target_dicts, data, params,

target_outputs[qualified_target] = target

if qualified_target in all_targets:

all_outputs.add(target.FinalOutput())

+ else:

+ target_short_names.setdefault(name, [])

if target_short_names:

# Write a short name to build this target. This benefits both the

« no previous file with comments | « no previous file | test/ninja/none-rules/gyptest-none-rules.py » ('j') | no next file with comments »