Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/stub-cache.cc

Issue 203303010: Fix polymorphic keyed loads for SLOPPY_ARGUMENTS_ELEMENTS (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: added missing test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | test/mjsunit/regress/regress-crbug-350867.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1288 matching lines...) Expand 10 before | Expand all | Expand 10 after
1299 } else { 1299 } else {
1300 bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE; 1300 bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE;
1301 ElementsKind elements_kind = receiver_map->elements_kind(); 1301 ElementsKind elements_kind = receiver_map->elements_kind();
1302 1302
1303 if (IsFastElementsKind(elements_kind) || 1303 if (IsFastElementsKind(elements_kind) ||
1304 IsExternalArrayElementsKind(elements_kind) || 1304 IsExternalArrayElementsKind(elements_kind) ||
1305 IsFixedTypedArrayElementsKind(elements_kind)) { 1305 IsFixedTypedArrayElementsKind(elements_kind)) {
1306 cached_stub = 1306 cached_stub =
1307 KeyedLoadFastElementStub(is_js_array, 1307 KeyedLoadFastElementStub(is_js_array,
1308 elements_kind).GetCode(isolate()); 1308 elements_kind).GetCode(isolate());
1309 } else if (elements_kind == SLOPPY_ARGUMENTS_ELEMENTS) {
1310 cached_stub = isolate()->builtins()->KeyedLoadIC_SloppyArguments();
1309 } else { 1311 } else {
1310 ASSERT(elements_kind == DICTIONARY_ELEMENTS); 1312 ASSERT(elements_kind == DICTIONARY_ELEMENTS);
1311 cached_stub = KeyedLoadDictionaryElementStub().GetCode(isolate()); 1313 cached_stub = KeyedLoadDictionaryElementStub().GetCode(isolate());
1312 } 1314 }
1313 } 1315 }
1314 1316
1315 handlers->Add(cached_stub); 1317 handlers->Add(cached_stub);
1316 } 1318 }
1317 } 1319 }
1318 1320
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
1487 Handle<FunctionTemplateInfo>( 1489 Handle<FunctionTemplateInfo>(
1488 FunctionTemplateInfo::cast(signature->receiver())); 1490 FunctionTemplateInfo::cast(signature->receiver()));
1489 } 1491 }
1490 } 1492 }
1491 1493
1492 is_simple_api_call_ = true; 1494 is_simple_api_call_ = true;
1493 } 1495 }
1494 1496
1495 1497
1496 } } // namespace v8::internal 1498 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | test/mjsunit/regress/regress-crbug-350867.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698