Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: Source/modules/webdatabase/DatabaseSync.h

Issue 203303009: Oilpan: Add a comment to a Persistent data member in DatabaseSync. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/DatabaseSync.h
diff --git a/Source/modules/webdatabase/DatabaseSync.h b/Source/modules/webdatabase/DatabaseSync.h
index f1317c36cb352ab0dbb02cb1f44a7fc390472f99..d3cea75ca7088fbf06f08c9572f4e85faaf2a9b8 100644
--- a/Source/modules/webdatabase/DatabaseSync.h
+++ b/Source/modules/webdatabase/DatabaseSync.h
@@ -88,6 +88,11 @@ private:
SQLTransactionSync& m_transaction;
};
+ // Need a Persistent field because a HeapHashMap entry should be removed
+ // just after a SQLTransactionSync becomes untraceable. If this field was a
+ // Member<>, we could not assume the destruction order of DatabaseSync,
+ // SQLTransactionSync, and the field. We can not make the field static
+ // because multiple worker threads create SQLTransactionSync.
GC_PLUGIN_IGNORE("http://crbug.com/353083")
PersistentHeapHashMap<WeakMember<SQLTransactionSync>, OwnPtr<TransactionObserver> > m_observers;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698