Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: content/child/webcrypto/webcrypto_util.cc

Issue 203303006: [webcrypto] Add length parameter to HmacKeyAlgorithm. (chromium) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/shared_crypto_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/webcrypto_util.cc
diff --git a/content/child/webcrypto/webcrypto_util.cc b/content/child/webcrypto/webcrypto_util.cc
index 5e5fc8e4c3d2b7857e438bdb0c32e5af6f59f2f0..2b11ac1df1939f3c6720fbb0a6585b4c79f9d228 100644
--- a/content/child/webcrypto/webcrypto_util.cc
+++ b/content/child/webcrypto/webcrypto_util.cc
@@ -385,7 +385,12 @@ bool CreateSecretKeyAlgorithm(const blink::WebCryptoAlgorithm& algorithm,
if (hash.isNull())
return false;
*key_algorithm = blink::WebCryptoKeyAlgorithm::adoptParamsAndCreate(
- algorithm.id(), new blink::WebCryptoHmacKeyAlgorithmParams(hash));
+ algorithm.id(),
+#if defined(WEBCRYPTO_HMAC_KEY_HAS_LENGTH)
+ new blink::WebCryptoHmacKeyAlgorithmParams(hash, keylen_bytes * 8));
eroman 2014/03/18 23:50:01 I didn't check for overflow, probably should. wdyt
eroman 2014/03/19 00:04:19 OK done.
+#else
+ new blink::WebCryptoHmacKeyAlgorithmParams(hash));
+#endif
return true;
}
case blink::WebCryptoAlgorithmIdAesKw:
« no previous file with comments | « content/child/webcrypto/shared_crypto_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698