Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 203303006: [webcrypto] Add length parameter to HmacKeyAlgorithm. (chromium) (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Add length parameter to HmacKeyAlgorithm. (chromium) Matches a planned change to the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25094 Blink side of this change: https://codereview.chromium.org/204013006/ BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257878

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Add bound check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M content/child/webcrypto/shared_crypto_unittest.cc View 1 6 chunks +22 lines, -0 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
eroman
https://codereview.chromium.org/203303006/diff/20001/content/child/webcrypto/webcrypto_util.cc File content/child/webcrypto/webcrypto_util.cc (right): https://codereview.chromium.org/203303006/diff/20001/content/child/webcrypto/webcrypto_util.cc#newcode390 content/child/webcrypto/webcrypto_util.cc:390: new blink::WebCryptoHmacKeyAlgorithmParams(hash, keylen_bytes * 8)); I didn't check for ...
6 years, 9 months ago (2014-03-18 23:50:01 UTC) #1
eroman
https://codereview.chromium.org/203303006/diff/20001/content/child/webcrypto/webcrypto_util.cc File content/child/webcrypto/webcrypto_util.cc (right): https://codereview.chromium.org/203303006/diff/20001/content/child/webcrypto/webcrypto_util.cc#newcode390 content/child/webcrypto/webcrypto_util.cc:390: new blink::WebCryptoHmacKeyAlgorithmParams(hash, keylen_bytes * 8)); On 2014/03/18 23:50:01, eroman ...
6 years, 9 months ago (2014-03-19 00:04:19 UTC) #2
Ryan Sleevi
lgtm
6 years, 9 months ago (2014-03-19 00:07:27 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-19 00:10:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/203303006/40001
6 years, 9 months ago (2014-03-19 00:13:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 00:21:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 00:21:21 UTC) #7
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-19 00:35:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/203303006/40001
6 years, 9 months ago (2014-03-19 00:39:43 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 01:09:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-19 01:09:34 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-19 01:39:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/203303006/40001
6 years, 9 months ago (2014-03-19 01:42:14 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 03:06:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-19 03:06:30 UTC) #15
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-19 03:37:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/203303006/40001
6 years, 9 months ago (2014-03-19 03:38:12 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 06:39:00 UTC) #18
Message was sent while issue was closed.
Change committed as 257878

Powered by Google App Engine
This is Rietveld 408576698