Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: blimp/engine/renderer/blob_channel_sender_proxy.h

Issue 2033013003: Use shared memory for moving data over BlobChannel Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-master
Patch Set: dcheng feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/renderer/blob_channel_sender_proxy.h
diff --git a/blimp/engine/renderer/blob_channel_sender_proxy.h b/blimp/engine/renderer/blob_channel_sender_proxy.h
index e219ef06c35e7ff5fda51bed6f00343a4bd8ceb7..d34e482459821a550b0341e15ef83613107680ea 100644
--- a/blimp/engine/renderer/blob_channel_sender_proxy.h
+++ b/blimp/engine/renderer/blob_channel_sender_proxy.h
@@ -21,8 +21,12 @@ namespace engine {
class BLIMP_COMMON_EXPORT BlobChannelSenderProxy : public BlobChannelSender {
public:
BlobChannelSenderProxy();
+
~BlobChannelSenderProxy() override;
+ static std::unique_ptr<BlobChannelSenderProxy> CreateForTest(
+ mojom::BlobChannelPtr blob_channel);
+
// Returns true if the blob is known to exist within the Engine cache.
bool IsInEngineCache(const std::string& id) const;
@@ -34,6 +38,9 @@ class BLIMP_COMMON_EXPORT BlobChannelSenderProxy : public BlobChannelSender {
void DeliverBlob(const BlobId& id) override;
private:
+ // Testing constructor, used to supply a BlobChannel Mojo proxy directly.
+ explicit BlobChannelSenderProxy(mojom::BlobChannelPtr blob_channel);
+
// BlobChannel Mojo IPC stub, used for delivering blobs to the browser
// process.
mojom::BlobChannelPtr blob_channel_;

Powered by Google App Engine
This is Rietveld 408576698