Use shared memory for moving data over BlobChannel Mojo interface.

blimp/engine/mojo/blob_channel_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/mojo/blob_channel_service.h"
 
 #include "blimp/net/blob_channel/blob_channel_sender.h"
+#include "mojo/public/cpp/system/buffer.h"
 
 namespace blimp {
 namespace engine {
 
 BlobChannelService::BlobChannelService(BlobChannelSender* blob_channel_sender,
                                        mojom::BlobChannelRequest request)
     : binding_(this, std::move(request)),
       blob_channel_sender_(blob_channel_sender) {
   DCHECK(blob_channel_sender_);
 }
 
 BlobChannelService::~BlobChannelService() {}
 
 void BlobChannelService::PutBlob(const mojo::String& id,
-                                 const mojo::String& data) {
-  blob_channel_sender_->PutBlob(id, new BlobData(data));
+                                 mojo::ScopedSharedBufferHandle data,
+                                 uint32_t size,
+                                 const PutBlobCallback& callback) {
+  // Map |data| into memory.
+  char* blob_buf = nullptr;
+  MojoResult result =
+      mojo::MapBuffer(data.get(), 0, size, reinterpret_cast<void**>(&blob_buf),
+                      MOJO_MAP_BUFFER_FLAG_NONE);
+  if (result != MOJO_RESULT_OK) {
+    LOG(ERROR) << "Couldn't map buffer for blob ID: " << id;
+    DLOG(FATAL) << "Exiting.";
+    return;
+  }
+  DCHECK(blob_buf);
+
+  scoped_refptr<BlobData> new_blob(new BlobData);
+  new_blob->data.assign(blob_buf, size);
+  blob_channel_sender_->PutBlob(id, std::move(new_blob));
+  result = mojo::UnmapBuffer(blob_buf);
+  if (result != MOJO_RESULT_OK) {
+    LOG(ERROR) << "Couldn't unmap buffer for blob ID: " << id;

[maniscalco, 2016/06/06 15:43:56]

Assuming mojo differentiates between different types of failure (e.g. permission
denied, too many open files), consider logging the error result.  That way, when
we see map/unmap failures we can more easily figure out the cause.

[Kevin M, 2016/06/09 00:08:32]

Done.

+    DLOG(FATAL) << "Exiting.";
+    return;
+  }
+
+  // Signals the renderer side that we are done with the shared memory |data|.
+  callback.Run();
 }
 
 void BlobChannelService::DeliverBlob(const mojo::String& id) {
   blob_channel_sender_->DeliverBlob(id);
 }
 
 // static
 void BlobChannelService::Create(
     BlobChannelSender* blob_channel_sender,
     mojo::InterfaceRequest<mojom::BlobChannel> request) {
   // Object lifetime is managed by BlobChannelService's StrongBinding
   // |binding_|.
   new BlobChannelService(blob_channel_sender, std::move(request));
 }
 
 }  // namespace engine
 }  // namespace blimp