Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: blimp/engine/mojo/blob_channel.mojom

Issue 2033013003: Use shared memory for moving data over BlobChannel Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-master
Patch Set: dcheng feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module blimp.engine.mojom; 5 module blimp.engine.mojom;
6 6
7 interface BlobChannel { 7 interface BlobChannel {
dcheng 2016/06/28 06:26:18 If possible, a comment describing this interface w
Kevin M 2016/06/28 18:18:53 Done, though I don't want to go into too much deta
8 // Stores the blob |id| in the BlobCache. 8 // Stores the blob |id| in the BlobCache.
9 // TODO(kmarshall): Use shared memory for more efficient data transfer, see 9 // Because the IPC channel is a shared resource and payloads can be quite
10 // crbug.com/614564 . 10 // large, we use shared memory to reduce channel contention and associated
11 PutBlob(string id, string data); 11 // latency with other components/features.
12 //
13 // The buffer is released when the callee discards the handle for |data|.
14 PutBlob(string id, handle<shared_buffer> data, uint32 size);
12 15
13 // Requests that the BlobChannel push the blob |id| over the wire. 16 // Requests that the BlobChannel push the blob |id| over the wire.
14 // The request will be ignored if the BlobChannel knows that 17 // The request will be ignored if the BlobChannel knows that
15 // the client already has the data. 18 // the client already has the data.
16 DeliverBlob(string id); 19 DeliverBlob(string id);
17 }; 20 };
18 21
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698