Use shared memory for moving data over BlobChannel Mojo interface.

blimp/engine/mojo/blob_channel_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/mojo/blob_channel_service.h"
 
 #include "blimp/net/blob_channel/blob_channel_sender.h"
+#include "mojo/public/cpp/system/buffer.h"
 
 namespace blimp {
 namespace engine {
 
 BlobChannelService::BlobChannelService(BlobChannelSender* blob_channel_sender,
                                        mojom::BlobChannelRequest request)
     : binding_(this, std::move(request)),
       blob_channel_sender_(blob_channel_sender) {
   DCHECK(blob_channel_sender_);
 }
 
 BlobChannelService::~BlobChannelService() {}
 
 void BlobChannelService::PutBlob(const mojo::String& id,
-                                 const mojo::String& data) {
-  blob_channel_sender_->PutBlob(id, new BlobData(data));
+                                 mojo::ScopedSharedBufferHandle data,
+                                 uint32_t size) {
+  // Map |data| into the address space and copy out its contents.
+  DCHECK(data.is_valid());

[dcheng, 2016/06/25 01:06:31]

The comments imply this is coming from the renderer. I'm a bit fuzzy on the
Blimp process model, but I guess the renderer is still untrusted? So it seems
like this needs to be an if (), not a DCHECK().

[Kevin M, 2016/06/27 17:31:12]

Done.

+  scoped_refptr<BlobData> new_blob(new BlobData);
+  auto mapping = data->Map(size);
+  new_blob->data.assign(reinterpret_cast<const char*>(mapping.get()), size);
+  blob_channel_sender_->PutBlob(id, std::move(new_blob));
 }
 
 void BlobChannelService::DeliverBlob(const mojo::String& id) {
   blob_channel_sender_->DeliverBlob(id);
 }
 
 // static
 void BlobChannelService::Create(
     BlobChannelSender* blob_channel_sender,
     mojo::InterfaceRequest<mojom::BlobChannel> request) {
   // Object lifetime is managed by BlobChannelService's StrongBinding
   // |binding_|.
   new BlobChannelService(blob_channel_sender, std::move(request));
 }
 
 }  // namespace engine
 }  // namespace blimp