Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2032973002: Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking" (patchset #7 id:180001 of https://codereview.chromium.org/2026633003/ ) Reason for revert: Also failing with the new implementation: https://build.chromium.org/p/chromium.gpu/builders/Linux%20Debug%20%28NVIDIA%29/builds/62646 Will do a local repro now. Original issue's description: > Track based on JSArrayBuffer addresses on pages instead of the attached > backing store. > > Details of tracking: > - Scavenge: New space pages are processes in bulk on the main thread > - MC: Unswept pages are processed in bulk in parallel. All other pages > are processed by the sweeper concurrently. > > BUG=chromium:611688 > LOG=N > TEST=cctest/test-array-buffer-tracker/* > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/279e274eccf95fbb4bd41d908b9153acf6ec118a > Cr-Commit-Position: refs/heads/master@{#36653} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:611688 Committed: https://crrev.com/5979bf56541db4d369580992954cef3c7b3acddd Cr-Commit-Position: refs/heads/master@{#36663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -589 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 chunk +40 lines, -59 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 chunk +112 lines, -148 lines 0 comments Download
M src/heap/heap.h View 4 chunks +6 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +11 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M src/heap/objects-visiting.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 4 chunks +35 lines, -8 lines 0 comments Download
M src/heap/scavenger.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +1 line, -22 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +1 line, -10 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -291 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
Created Revert of Reland "[heap] Fine-grained JSArrayBuffer tracking"
4 years, 6 months ago (2016-06-02 06:46:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032973002/1
4 years, 6 months ago (2016-06-02 06:46:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:46:57 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:47:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5979bf56541db4d369580992954cef3c7b3acddd
Cr-Commit-Position: refs/heads/master@{#36663}

Powered by Google App Engine
This is Rietveld 408576698