Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2032943003: Import owners bug fix and testing (Closed)

Created:
4 years, 6 months ago by raikiri
Modified:
4 years, 6 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change test_importer.py to skip importing files named OWNERS BUG=584660 Committed: https://crrev.com/7eaf84d3a96079670615da9de483f3ab82513865 Cr-Commit-Position: refs/heads/master@{#397750}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change test_importer.py to skip importing files named OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
raikiri
This is a fix for Issue 584660.
4 years, 6 months ago (2016-06-02 18:33:11 UTC) #2
qyearsley
LGTM Before committing, the CL description could be made clearer; something like: Change test_importer.py to ...
4 years, 6 months ago (2016-06-02 20:59:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032943003/20001
4 years, 6 months ago (2016-06-02 21:14:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/238211)
4 years, 6 months ago (2016-06-02 22:57:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032943003/20001
4 years, 6 months ago (2016-06-03 16:43:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 17:58:33 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:00:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7eaf84d3a96079670615da9de483f3ab82513865
Cr-Commit-Position: refs/heads/master@{#397750}

Powered by Google App Engine
This is Rietveld 408576698