Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2032923002: [Chromecast] Make EME persistent license support optional (Closed)

Created:
4 years, 6 months ago by halliwell
Modified:
4 years, 6 months ago
Reviewers:
yucliu1
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Make EME persistent license support optional The recent refactoring from KeySystemsInfo meant we lost the option to control whether persistent license support is enabled (see linked bug). Add the option back into the new system. BUG=internal b/28844432 Committed: https://crrev.com/73a640d498ea36d6c60daca10c5a2b7979511660 Cr-Commit-Position: refs/heads/master@{#397827}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/key_systems_cast.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 4 chunks +13 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
halliwell
4 years, 6 months ago (2016-06-02 03:16:30 UTC) #3
yucliu1
https://codereview.chromium.org/2032923002/diff/1/chromecast/renderer/key_systems_cast.cc File chromecast/renderer/key_systems_cast.cc (right): https://codereview.chromium.org/2032923002/diff/1/chromecast/renderer/key_systems_cast.cc#newcode87 chromecast/renderer/key_systems_cast.cc:87: bool enable_persistent_license_support) { Is the flag only for playready?
4 years, 6 months ago (2016-06-02 16:31:52 UTC) #4
halliwell
On 2016/06/02 16:31:52, yucliu1 wrote: > https://codereview.chromium.org/2032923002/diff/1/chromecast/renderer/key_systems_cast.cc > File chromecast/renderer/key_systems_cast.cc (right): > > https://codereview.chromium.org/2032923002/diff/1/chromecast/renderer/key_systems_cast.cc#newcode87 > ...
4 years, 6 months ago (2016-06-02 16:39:33 UTC) #5
yucliu1
On 2016/06/02 16:39:33, halliwell wrote: > On 2016/06/02 16:31:52, yucliu1 wrote: > > > https://codereview.chromium.org/2032923002/diff/1/chromecast/renderer/key_systems_cast.cc ...
4 years, 6 months ago (2016-06-02 16:47:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032923002/1
4 years, 6 months ago (2016-06-03 21:05:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 22:41:23 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:43:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73a640d498ea36d6c60daca10c5a2b7979511660
Cr-Commit-Position: refs/heads/master@{#397827}

Powered by Google App Engine
This is Rietveld 408576698