content/browser/frame_host/navigator_impl.cc - Issue 2032903007: Allow about:blank to be considered in-page if origin matches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2032903007: Allow about:blank to be considered in-page if origin matches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests and add test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 51338362e448590e0fa1590bc3b6e21467528b02..3a9051c3c135ab3db74dc382e8ffdd3567c1a1fd 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -476,7 +476,8 @@ void NavigatorImpl::DidNavigate(

has_embedded_credentials);

bool is_navigation_within_page = controller_->IsURLInPageNavigation(

Charlie Reis 2016/06/06 19:30:54 I also plan to make this the only call site of IsU

Avi (use Gerrit) 2016/06/06 19:46:41 Acknowledged.

- params.url, params.was_within_same_page, render_frame_host);

+ params.url, params.origin, params.was_within_same_page,

+ render_frame_host);

// If a frame claims it navigated within page, it must be the current frame,

// not a pending one.