Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2032903002: [ios] Added WebTestWithWebController::web_state. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added WebTestWithWebController::web_state. Subclasses of WebTestWithWebController should use WebState where possible. BUG=616244 Committed: https://crrev.com/2924a66000830f14055b5c087c0861a532c6a7fb Cr-Commit-Position: refs/heads/master@{#397723}

Patch Set 1 #

Patch Set 2 : Moved WebTestWithWebController::web_state to implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ios/web/test/web_test.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/test/web_test.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-02 01:56:09 UTC) #2
kkhorimoto
lgtm
4 years, 6 months ago (2016-06-02 20:42:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032903002/1
4 years, 6 months ago (2016-06-02 20:42:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/15490)
4 years, 6 months ago (2016-06-02 21:04:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032903002/20001
4 years, 6 months ago (2016-06-03 15:46:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 16:25:22 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:26:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2924a66000830f14055b5c087c0861a532c6a7fb
Cr-Commit-Position: refs/heads/master@{#397723}

Powered by Google App Engine
This is Rietveld 408576698