chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js - Issue 2032893004: Disable LanguageOptionsDictionaryDownloadWebUITest.testdictionaryDownloadRetry on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

Issue 2032893004: Disable LanguageOptionsDictionaryDownloadWebUITest.testdictionaryDownloadRetry on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

diff --git a/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js b/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

index 297335f1eb14d9469b067ed3eb69af0f263e50e9..174b32365a47ccb98e400e9a01f11b7a68fb3ab7 100644

--- a/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

+++ b/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js

@@ -110,8 +110,15 @@ TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

});

// Verify that clicking the retry button calls the handler.

+// This test is flaky on Windows. https://crbug.com/616791

+GEN('#if defined(OS_WIN)');

+GEN('#define MAYBE_testdictionaryDownloadRetry ' +

+ 'DISABLED_testdictionaryDownloadRetry');

+GEN('#else');

+GEN('#define MAYBE_testdictionaryDownloadRetry testdictionaryDownloadRetry');

+GEN('#endif // defined(OS_WIN)');

TEST_F('LanguagesOptionsDictionaryDownloadWebUITest',

- 'testdictionaryDownloadRetry',

+ 'MAYBE_testdictionaryDownloadRetry',

function() {

this.mockHandler.expects(once()).retryDictionaryDownload('en-US').

will(callFunction(function() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »