Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2032893003: ServiceWorker: Fix the argument of ctor of Response (Closed)

Created:
4 years, 6 months ago by shimazu
Modified:
4 years, 6 months ago
Reviewers:
sullivan, peria
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Fix the argument of ctor of Response The first argument to Response constructor should be the body while currently passing the header. This patch fixed it and updated the pageset. BUG=614985 Committed: https://crrev.com/622df80e954a2ead9cdd6f242ae7bf301dd81bda Cr-Commit-Position: refs/heads/master@{#397891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/perf/page_sets/data/service_worker_micro_benchmark.json View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/service_worker_micro_benchmark_004.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/service_worker_micro_benchmark.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
shimazu
PTAL:)
4 years, 6 months ago (2016-06-02 04:19:31 UTC) #2
peria
Hi Shimazu-san, This CL looks trivial and good to me, but my l-g-t-m is allowed ...
4 years, 6 months ago (2016-06-02 04:44:21 UTC) #3
shimazu
Thanks, and add sullivan@. PTAL:)
4 years, 6 months ago (2016-06-02 05:04:56 UTC) #5
sullivan
lgtm
4 years, 6 months ago (2016-06-03 21:00:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032893003/1
4 years, 6 months ago (2016-06-04 00:51:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 02:18:32 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 02:19:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/622df80e954a2ead9cdd6f242ae7bf301dd81bda
Cr-Commit-Position: refs/heads/master@{#397891}

Powered by Google App Engine
This is Rietveld 408576698