Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2032893002: Fix two build failures - for typeProvider and findElement. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 6 months ago (2016-06-02 01:53:13 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as a6b93661fd2200d3004d9f7b71cd0f8513f7577b (presubmit successful).
4 years, 6 months ago (2016-06-02 01:54:16 UTC) #3
Paul Berry
lgtm https://codereview.chromium.org/2032893002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/2032893002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode469 pkg/analyzer/lib/src/context/context.dart:469: // The `AnalysisContextTarget.request` results to into the SDK ...
4 years, 6 months ago (2016-06-02 12:09:36 UTC) #4
Brian Wilkerson
4 years, 6 months ago (2016-06-02 13:57:38 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698