Issue 2032843002: WebUI: add global "locale" key to loadTimeData in many cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2032843002: WebUI: add global "locale" key to loadTimeData in many cases (Closed)

Created:
4 years, 6 months ago by Dan Beam

Modified:
4 years, 6 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WebUI: add global "locale" key to loadTimeData in many cases Will be helpful when localizing numbers via toLocaleString() in JS. R=jshin@chromium.org BUG=613331

Patch Set 1 : . #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	ui/base/webui/web_ui_util.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ui/base/webui/web_ui_util_unittest.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Beam

i don't know how helpful the unit test is, but it only took me like ...

4 years, 6 months ago (2016-06-02 01:02:36 UTC) #2

Message was sent while issue was closed.

closing until needed

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages