Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032803002: Set Deduplicators in ProcessMemoryDumpTest.TakeAllDumpsFrom (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set Deduplicators in ProcessMemoryDumpTest.TakeAllDumpsFrom We need to set them to avoid null pointer dereference. BUG=616268 Committed: https://crrev.com/425e3fe4d120e37f6c45e1b38f62cb2f1048a4ff Cr-Commit-Position: refs/heads/master@{#397503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M base/trace_event/process_memory_dump_unittest.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bashi
PTAL?
4 years, 6 months ago (2016-06-01 23:26:55 UTC) #2
Primiano Tucci (use gerrit)
Oops. Thanks so much. LGTM
4 years, 6 months ago (2016-06-02 19:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032803002/1
4 years, 6 months ago (2016-06-02 19:15:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 20:52:15 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 20:54:43 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/425e3fe4d120e37f6c45e1b38f62cb2f1048a4ff
Cr-Commit-Position: refs/heads/master@{#397503}

Powered by Google App Engine
This is Rietveld 408576698