Issue 20328002: pdfviewer: gyp does not run in a consistent way on various palt forms, and it generates some files …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20328002: pdfviewer: gyp does not run in a consistent way on various palt forms, and it generates some files … (Closed)

Created:
7 years, 5 months ago by edisonn

Modified:
7 years, 5 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdfviewer: update drawBitmap, and fic a gyp issue: gyp does not run in a consistent way on various palt forms, and it generates some files in ../../../foo instead of ../foo - Solution: use the (inconvenient) Shared intermediary directory that should work on all platforms. Committed: https://code.google.com/p/skia/source/detail?r=10359

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -14 lines)			Patch
	M	experimental/PdfViewer/generate_code.py	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
	M	gyp/pdfviewer.gyp	View	1	2 chunks	+21 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

edisonn

7 years, 5 months ago (2013-07-25 15:33:16 UTC) #1

Message was sent while issue was closed.

Committed patchset #3 manually as r10359 (presubmit successful).

Expand Messages | Collapse Messages