CSP: Add line numbers to reports whenever we have them.
Following up on https://codereview.chromium.org/2020053002, we have
line numbers in a variety of cases today, but we're only dumping them
into the reports when a script file generated the error. This patch
ensures that line/column data is appended whenever it's available.
BUG=615862
Committed: https://crrev.com/5b144f48b84c94de36d4bb842f5a72387beb4612
Cr-Commit-Position: refs/heads/master@{#398006}
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032793004/1
4 years, 6 months ago
(2016-06-03 12:22:10 UTC)
#4
Ah, Philip is OOO. Jochen or Yoav, would one of you mind taking a look ...
4 years, 6 months ago
(2016-06-06 11:09:28 UTC)
#14
Ah, Philip is OOO. Jochen or Yoav, would one of you mind taking a look at this
tiny change?
Yoav Weiss
On 2016/06/06 11:09:28, Mike West (OOO until 30th) wrote: > Ah, Philip is OOO. Jochen ...
4 years, 6 months ago
(2016-06-06 11:11:39 UTC)
#15
On 2016/06/06 11:09:28, Mike West (OOO until 30th) wrote:
> Ah, Philip is OOO. Jochen or Yoav, would one of you mind taking a look at this
> tiny change?
LGTM
Mike West
The CQ bit was checked by mkwst@chromium.org
4 years, 6 months ago
(2016-06-06 11:51:41 UTC)
#16
4 years, 6 months ago
(2016-06-06 11:56:09 UTC)
#18
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== CSP: Add line numbers to reports whenever we have them. ...
4 years, 6 months ago
(2016-06-06 11:58:03 UTC)
#19
Message was sent while issue was closed.
Description was changed from
==========
CSP: Add line numbers to reports whenever we have them.
Following up on https://codereview.chromium.org/2020053002, we have
line numbers in a variety of cases today, but we're only dumping them
into the reports when a script file generated the error. This patch
ensures that line/column data is appended whenever it's available.
BUG=615862
==========
to
==========
CSP: Add line numbers to reports whenever we have them.
Following up on https://codereview.chromium.org/2020053002, we have
line numbers in a variety of cases today, but we're only dumping them
into the reports when a script file generated the error. This patch
ensures that line/column data is appended whenever it's available.
BUG=615862
Committed: https://crrev.com/5b144f48b84c94de36d4bb842f5a72387beb4612
Cr-Commit-Position: refs/heads/master@{#398006}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b144f48b84c94de36d4bb842f5a72387beb4612 Cr-Commit-Position: refs/heads/master@{#398006}
4 years, 6 months ago
(2016-06-06 11:58:04 UTC)
#20
Issue 2032793004: CSP: Add line numbers to reports whenever we have them.
(Closed)
Created 4 years, 6 months ago by Mike West
Modified 4 years, 6 months ago
Reviewers: jochen (gone - plz use gerrit), Yoav Weiss
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0