Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2032793004: CSP: Add line numbers to reports whenever we have them. (Closed)

Created:
4 years, 6 months ago by Mike West
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: Add line numbers to reports whenever we have them. Following up on https://codereview.chromium.org/2020053002, we have line numbers in a variety of cases today, but we're only dumping them into the reports when a script file generated the error. This patch ensures that line/column data is appended whenever it's available. BUG=615862 Committed: https://crrev.com/5b144f48b84c94de36d4bb842f5a72387beb4612 Cr-Commit-Position: refs/heads/master@{#398006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-only-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-multiple-reversed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (9 generated)
Mike West
Mind taking a look at this, Philip? Tiny change, I hope. :)
4 years, 6 months ago (2016-06-03 11:08:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032793004/1
4 years, 6 months ago (2016-06-03 12:22:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 13:09:03 UTC) #6
Mike West
On 2016/06/03 at 13:09:03, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 6 months ago (2016-06-06 07:37:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032793004/1
4 years, 6 months ago (2016-06-06 07:38:04 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 09:19:54 UTC) #11
Mike West
Ah, Philip is OOO. Jochen or Yoav, would one of you mind taking a look ...
4 years, 6 months ago (2016-06-06 11:09:28 UTC) #14
Yoav Weiss
On 2016/06/06 11:09:28, Mike West (OOO until 30th) wrote: > Ah, Philip is OOO. Jochen ...
4 years, 6 months ago (2016-06-06 11:11:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032793004/1
4 years, 6 months ago (2016-06-06 11:51:52 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 11:56:09 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 11:58:04 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b144f48b84c94de36d4bb842f5a72387beb4612
Cr-Commit-Position: refs/heads/master@{#398006}

Powered by Google App Engine
This is Rietveld 408576698