Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2032793003: Get rid of unused android GetHandle() and FPF_HFONT (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Get rid of unused android GetHandle() and FPF_HFONT git grep FPF_HFONT git grep '\bGetHandle\b' show these are unused. Committed: https://pdfium.googlesource.com/pdfium/+/25dc95a3cb9099550fa4d9d4f1c74b0f996fbc41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M core/fxge/android/fpf_skiafont.h View 2 chunks +0 lines, -3 lines 0 comments Download
M core/fxge/android/fpf_skiafont.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Lei, nothing but red.
4 years, 6 months ago (2016-06-02 21:27:49 UTC) #2
Tom Sepez
dan
4 years, 6 months ago (2016-06-06 19:05:11 UTC) #5
dsinclair
lgtm
4 years, 6 months ago (2016-06-06 19:53:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032793003/1
4 years, 6 months ago (2016-06-06 19:53:07 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:09:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/25dc95a3cb9099550fa4d9d4f1c74b0f996f...

Powered by Google App Engine
This is Rietveld 408576698